Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4900: New model for cable paths #5212

Merged
merged 67 commits into from
Oct 8, 2020
Merged

#4900: New model for cable paths #5212

merged 67 commits into from
Oct 8, 2020

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Oct 5, 2020 •
edited
Loading

Closes: #4900

  • Introduce a new CablePath model for recording the origin, destination, intermediate nodes, and status of each end-to-end path
  • Add a ForeignKey to CablePath on each of the seven path endpoint models
  • Drop the old fields for connected_endpoint and connection_status
  • Cache peer termination on CableTermination instances
  • Remove trace API endpoint from FrontPort and RearPort
  • Remove connection_status field from nested API serializers for device components
  • Add cable_peer field to API serializer for all CableTermination models
  • Overhaul cable tracing logic with the new trace_paths() utility function
  • Completely rewrite all cable path tests
  • Add the retrace_paths management command (temporarily?)

@jeremystretch
Initial work on cable paths (WIP)
587e6fc
@jeremystretch
Add initial tests
9851977
@jeremystretch
Extend cable path tests
319329e
@jeremystretch
Ignore the position stack when traversing single-position rear ports
cd71799
@jeremystretch
Extend cable path tests
e53ae1d
@jeremystretch
Remove extraneous test objects
46df5a9
@jeremystretch
Add GenericRelation to originating cable paths on PathEndpoint
19a3a4d
@jeremystretch
Introduce retrace_paths management command
105c0fd
@jeremystretch
CircuitTermination and PowerFeed are path endpoints
8abc055
@jeremystretch
retrace_paths should ignore case in model names
cd398b1
@jeremystretch
Drop support for split paths
610420c
@jeremystretch
Capture path end-to-end status in CablePath
c974c56
@jeremystretch
Add test for connecting cables out of order
0d07b03
@jeremystretch
Add test for updated paths on cable status change
3b0a75e
@jeremystretch
Add tests for multiple pass-through breakouts
d50a0d9
@jeremystretch
Remove legacy CablePathTestCase
9d10c57
@jeremystretch
Rename test elements to be more readable
9f24221
@jeremystretch
Add tests for all PathEndpoint classes
4fd1219
@jeremystretch
Remove dcim.tests.test_api.ConnectionTest
e0abd7e
@jeremystretch
CablePath.origin should be unique
66355da
@jeremystretch
Replace connection_status filter with is_connected
aa0d4c4
@jeremystretch
Replace legacy trace() method
e9da84f
@jeremystretch
Add trace view for PowerFeed
7ff247c
@jeremystretch
Update console/power/interface connection tables
8cb636b
@jeremystretch
Cache each CablePath on its originating endpoint
5737f6f
@jeremystretch
Optimize console/power/interface connection lists
f8800b8
@jeremystretch
Remove legacy connected endpoint fields
079c422
@jeremystretch
Remove legacy connection_status fields
df73737
@jeremystretch
Initial changelog notes for #4900
13db22d
@jeremystretch
Rename CablePath.is_connected to is_active
3d34f1c
@jeremystretch jeremystretch changed the title #4900: New model for cable paths (DRAFT) #4900: New model for cable paths Oct 7, 2020
@jeremystretch jeremystretch marked this pull request as ready for review October 7, 2020 15:48
@jeremystretch
Copy link
Member Author

To avoid jamming any complex logic into schema migrations, I've opted to retain the trace_paths management command and call it within upgrade.sh. This will, by default, automatically create any missing CablePaths. In theory, this should be necessary only when upgrading to v2.10, however I've also included a --force option to force the recalculation of all CablePath objects should the need arise.

I'm still mulling options for conveying the presence of multiple cable paths through a RearPort with multiple FrontPorts mapped to it in the REST API. I've dropped the /trace/ endpoint from pass-through ports for now.

@jeremystretch jeremystretch merged commit 6470613 into develop-2.10 Oct 8, 2020
@jeremystretch jeremystretch deleted the 4900-cable-paths branch October 8, 2020 19:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glennmatthews glennmatthews glennmatthews left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @glennmatthews